Forum:Revolution calculator addition

Forums: Yew Grove > Revolution calculator addition

If you've been following a few things I've been talking about recently - or watching my contribs - you'll probably know I've been working on a revolution calculator, to calculate average ability damage per tick values (the same way the ones on Revolution are calculated). Well, now its done (for the time being). I'm not going to go into detail about it, since I've already written some documentation which does that. You can find the script at User:Gaz Lloyd/rev.js and the calculator and documentation at User:Gaz Lloyd/Sandbox 3.

I'm here for a few things:

• Rubber stamping the addition of the script to MediaWiki:Common.js
  • Including the creation/move of the script from my userspace to MediaWiki:Common.js/rev.js and MediaWiki:Common.css/rev.css
  • Including the creation/move of the calculator from my userspace to somewhere in the calculator namespace, with links from various places
• Feedback on a bunch of things:
  • Bugs! The most important part. Mess around with it and see if you can get it to break or do something unexpected and report it so it can be fixed.
  • Look and usage. Does it look okay and is it intuitive to use?
  • Documentation. Is the documentation (to be included with the calculator) easy enough to understand? Should it/parts be simplified or further expanded on?
  • More technical feedback:
    • Algorithms used. Any more efficient/better? I know the cycle-finding algorithm could maybe be better, but its not exactly easy to find anything about this sort of problem - there's things that are similar, but just different enough to be unusable, and there's clashes with the mathematical definition of cycle, which is completely different from this. (The algorithms used are currently documented with the calculator, but will probably be a subpage upon move.)
    • Javascript implementation. Is the structure and flow of the javascript good? Is the resulting output (in terms of HTML structure) good? (I have had a few others look at the JS already, but the more the merrier.)

To use the script, there's two options:

• Add the following to your common.js:

if ($('#ponies2').length > 0) {
    importArticles({type: 'script', articles: ['User:Gaz Lloyd/rev.js']});
}

(if you already use an importArticles statement, you can use a solution like I have to make sure it only loads on the relevant page - its a hefty script, you don't want it on every page load)

• If you have Greasmonkey or Tampermonkey, you can copy the entirety of User:Gaz Lloyd/rev.js into a new script, change the very bottom line from }(this.jQuery, this.mw)); to }(jQuery, mw)); (remove both this.) and save. It should work fine with both (though I haven't tested greasemonkey).

Imported on specific page via MediaWiki:Common.js. User:Cqm/Signature

Once installed, head to User:Gaz Lloyd/Sandbox 3 and it should be there (you may need to force refresh). The documentation is also there to explain how to use it, and what the settings do.

Cheers!  @Gaz#7521 23:02, March 24, 2015 (UTC)

Addendum - SPECIAL THANKS TO COOK FOR HIS JAVA CODE THAT STARTED THE PROCESS.  @Gaz#7521 00:55, March 25, 2015 (UTC)

Discussion

Support - You did indeed do a thing. MolMan 23:03, March 24, 2015 (UTC)

Support and Comment - It looked good when I tested it the other day. I also imported it via the Common.js on the test page to save the everyone the effort :). User:Cqm/Signature

thx bbe  @Gaz#7521 00:27, March 25, 2015 (UTC)

Support and Comment - Bug? Otherwise, you have my full support. Heaven Sent (talk) 03:34, March 25, 2015 (UTC)

Fixed it. (It was failing to account for stunbuffed abilities in the preamble, which caused 2 issues. You may need to force refresh again.) Thanks!  @Gaz#7521 04:11, March 25, 2015 (UTC)

Oppose - user is clearly only hear to disrupt the community and should not be trusted Andrew ^talk Support - good stuff, m8 Andrew ^talk 04:14, March 25, 2015 (UTC)